Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix created_by migration field #1713

Merged
merged 5 commits into from Oct 13, 2022
Merged

fix: fix created_by migration field #1713

merged 5 commits into from Oct 13, 2022

Conversation

KamilPawel
Copy link
Collaborator

@KamilPawel KamilPawel commented Oct 13, 2022

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Merging #1713 (2f38e50) into master (8e84d07) will increase coverage by 21.65%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1713       +/-   ##
===========================================
+ Coverage   66.30%   87.95%   +21.65%     
===========================================
  Files         179       38      -141     
  Lines        3659     1046     -2613     
  Branches      255      109      -146     
===========================================
- Hits         2426      920     -1506     
+ Misses       1201      103     -1098     
+ Partials       32       23        -9     
Impacted Files Coverage Δ
aimmo/migrations/0030_update_created_by.py
aimmo/templatetags/players_utils.py
game_frontend/src/babylon/entities/index.ts
...tions/0018_set_worksheet_2_as_default_for_games.py
aimmo/avatar_examples/simple_avatar.py
game_frontend/src/components/icons/Clear.js
game_frontend/src/theme.js
game_frontend/src/img/1_investigate.svg
...mmo/migrations/0022_allow_games_to_have_no_name.py
game_frontend/src/components/Code/index.js
... and 133 more

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

@faucomte97 faucomte97 merged commit 3ceedb0 into master Oct 13, 2022
@faucomte97 faucomte97 deleted the aimmo_fix branch October 13, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants