Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update k8s api #1715

Merged
merged 12 commits into from
Oct 20, 2022
Merged

fix: Update k8s api #1715

merged 12 commits into from
Oct 20, 2022

Conversation

faucomte97
Copy link
Member

@faucomte97 faucomte97 commented Oct 20, 2022

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Oct 20, 2022
Copy link
Collaborator

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 9 of 10 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @faucomte97)


aimmo-game-creator/Dockerfile line 3 at r2 (raw file):

FROM python:3.7.12-buster as builder
LABEL Author='codeforlife@ocado.com'

? :)

Copy link
Collaborator

@KamilPawel KamilPawel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 enabled auto-merge (squash) October 20, 2022 14:25
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #1715 (bdc5163) into master (45e0fcf) will increase coverage by 21.70%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1715       +/-   ##
===========================================
+ Coverage   66.24%   87.95%   +21.70%     
===========================================
  Files         179       38      -141     
  Lines        3662     1046     -2616     
  Branches      252      109      -143     
===========================================
- Hits         2426      920     -1506     
+ Misses       1204      103     -1101     
+ Partials       32       23        -9     
Impacted Files Coverage Δ
aimmo-game/setup.py
game_frontend/src/babylon/assetPacks/ancient.ts
aimmo/migrations/0024_unique_class_per_game.py
...mo/migrations/0019_game_has_worksheet_and_class.py
game_frontend/src/components/Badge/badges.js
..._frontend/src/redux/features/ConsoleLog/actions.js
game_frontend/src/babylon/diff.ts
game_frontend/src/testHelpers/mockEnvironment.ts
...e_frontend/src/redux/features/Analytics/actions.js
example_project/settings.py
... and 133 more

@faucomte97 faucomte97 merged commit 3ec86ac into master Oct 20, 2022
@faucomte97 faucomte97 deleted the update_k8s_api branch August 9, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants