Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Game class show fix #1719

Merged
merged 3 commits into from Oct 27, 2022
Merged

fix: Game class show fix #1719

merged 3 commits into from Oct 27, 2022

Conversation

KamilPawel
Copy link
Collaborator

@KamilPawel KamilPawel commented Oct 27, 2022

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

@KamilPawel KamilPawel self-assigned this Oct 27, 2022
@faucomte97 faucomte97 changed the title fix:Game class show fix fix: Game class show fix Oct 27, 2022
Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #1719 (3ddba20) into master (54355c8) will increase coverage by 21.70%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1719       +/-   ##
===========================================
+ Coverage   66.24%   87.95%   +21.70%     
===========================================
  Files         179       38      -141     
  Lines        3662     1046     -2616     
  Branches      252      109      -143     
===========================================
- Hits         2426      920     -1506     
+ Misses       1204      103     -1101     
+ Partials       32       23        -9     
Impacted Files Coverage Δ
aimmo/templatetags/players_utils.py
example_project/settings.py
aimmo/migrations/0016_game_class.py
aimmo/models.py
game_frontend/src/img/1_investigate.svg
aimmo-game/simulation/action.py
game_frontend/src/redux/features/Editor/actions.js
aimmo/migrations/0002_auto_20160601_1914.py
aimmo-game/simulation/direction.py
aimmo/migrations/0024_unique_class_per_game.py
... and 133 more

@KamilPawel KamilPawel enabled auto-merge (squash) October 27, 2022 14:41
@KamilPawel KamilPawel merged commit 521ffc1 into master Oct 27, 2022
@faucomte97 faucomte97 deleted the game_class_show_fix branch August 9, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants