Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: kurono ui update #1745

Merged
28 commits merged into from
Mar 16, 2023
Merged

fix: kurono ui update #1745

28 commits merged into from
Mar 16, 2023

Conversation

KamilPawel
Copy link
Collaborator

@KamilPawel KamilPawel commented Mar 1, 2023

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 5 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)

a discussion (no related file):
Please fix capitalisation of buttons + move clear console button to its own bar so the logs don't get written behind it


Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r3, 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @KamilPawel)


game_frontend/src/containers/IDEEditor/index.js line 107 at r4 (raw file):

          value={this.state.code}
          width="100%"
          height="56vh"

problem

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 5 files at r5, 9 of 10 files at r6, 2 of 2 files at r7, 1 of 1 files at r8, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @KamilPawel)

a discussion (no related file):

Previously, faucomte97 (Florian Aucomte) wrote…

Please fix capitalisation of buttons + move clear console button to its own bar so the logs don't get written behind it

"Console Log" still needs to be un-capitalised


a discussion (no related file):
The "Exit game" button is missing an icon (cf Miro) https://miro.com/app/board/uXjVOwwbTqY=/
Can we add it in?



game_frontend/src/components/ClearConsoleBar/index.js line 27 at r8 (raw file):

      <StyledConsoleTitle>
        <ClearButton
          variant="outlined"

The mockups show the buttons don't have an outline - can you please remove it from this button as well as the "Exit game" button? 🙏


game_frontend/src/components/ClearConsoleBar/index.js line 29 at r8 (raw file):

          variant="outlined"
          onClick={props.clearConsoleClicked}
          startIcon={<ClearIcon />}

The icons and the text for all the buttons are not quite aligned, the text isn't quite centered in the button. It would look nicer if the text was centered with the icon.

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r9, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)


game_frontend/src/components/ClearConsoleBar/index.js line 29 at r8 (raw file):

Previously, faucomte97 (Florian Aucomte) wrote…

The icons and the text for all the buttons are not quite aligned, the text isn't quite centered in the button. It would look nicer if the text was centered with the icon.

Actually they're still not aligned 😞

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r10, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #1745 (94f58ff) into master (0179ad7) will increase coverage by 87.95%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1745       +/-   ##
===========================================
+ Coverage        0   87.95%   +87.95%     
===========================================
  Files           0       38       +38     
  Lines           0     1046     +1046     
  Branches        0      109      +109     
===========================================
+ Hits            0      920      +920     
- Misses          0      103      +103     
- Partials        0       23       +23     

see 38 files with indirect coverage changes

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 3 files at r11, 1 of 1 files at r12, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

@ghost ghost merged commit 536e78e into master Mar 16, 2023
@ghost ghost deleted the IDEmain branch March 16, 2023 13:44
@ghost ghost restored the IDEmain branch March 16, 2023 13:44
@ghost ghost deleted the IDEmain branch March 20, 2023 15:28
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants