-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Update kurono avatar #1749
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @KamilPawel)
aimmo/static/babylon/models/avatar_marker_model_new.babylon
line 0 at r3 (raw file):
Could we simply overwrite the old file instead of creating a new file called _new
?
aimmo/static/babylon/models/avatar_marker_texture.png
line 0 at r3 (raw file):
Can this be compressed so it takes less space?
game_frontend/src/babylon/entities/avatarManager.ts
line 148 at r3 (raw file):
keyFrames.push({ frame: 0, value: 17,
Can MARKER_HEIGHT
be used here instead of the direct number? Same goes for the 2 other key frames below
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)
Codecov Report
@@ Coverage Diff @@
## master #1749 +/- ##
===========================================
+ Coverage 66.15% 87.95% +21.79%
===========================================
Files 178 38 -140
Lines 3667 1046 -2621
Branches 255 109 -146
===========================================
- Hits 2426 920 -1506
+ Misses 1209 103 -1106
+ Partials 32 23 -9 |
Description
How Has This Been Tested?
Checklist:
This change is![Reviewable](https://camo.githubusercontent.com/23b05f5fb48215c989e92cc44cf6512512d083132bd3daf689867c8d9d386888/68747470733a2f2f72657669657761626c652e696f2f7265766965775f627574746f6e2e737667)