Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update kurono avatar #1749

Merged
6 commits merged into from
Mar 13, 2023
Merged

fix: Update kurono avatar #1749

6 commits merged into from
Mar 13, 2023

Conversation

KamilPawel
Copy link
Collaborator

@KamilPawel KamilPawel commented Mar 10, 2023

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @KamilPawel)


aimmo/static/babylon/models/avatar_marker_model_new.babylon line 0 at r3 (raw file):
Could we simply overwrite the old file instead of creating a new file called _new?


aimmo/static/babylon/models/avatar_marker_texture.png line 0 at r3 (raw file):
Can this be compressed so it takes less space?


game_frontend/src/babylon/entities/avatarManager.ts line 148 at r3 (raw file):

    keyFrames.push({
      frame: 0,
      value: 17,

Can MARKER_HEIGHT be used here instead of the direct number? Same goes for the 2 other key frames below

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @KamilPawel)

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @KamilPawel)

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #1749 (ba7e79f) into master (739daf0) will increase coverage by 21.79%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1749       +/-   ##
===========================================
+ Coverage   66.15%   87.95%   +21.79%     
===========================================
  Files         178       38      -140     
  Lines        3667     1046     -2621     
  Branches      255      109      -146     
===========================================
- Hits         2426      920     -1506     
+ Misses       1209      103     -1106     
+ Partials       32       23        -9     

see 142 files with indirect coverage changes

@ghost ghost merged commit 8595805 into master Mar 13, 2023
@ghost ghost deleted the update_kurono_avatar branch March 20, 2023 15:18
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants