Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert changes #1774

Merged
merged 1 commit into from
May 25, 2023
Merged

fix: revert changes #1774

merged 1 commit into from
May 25, 2023

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented May 25, 2023

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

@SKairinos SKairinos linked an issue May 25, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #1774 (d367e49) into master (a7574d4) will increase coverage by 0.40%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1774      +/-   ##
==========================================
+ Coverage   66.32%   66.72%   +0.40%     
==========================================
  Files         179      182       +3     
  Lines        3661     3727      +66     
  Branches      255      264       +9     
==========================================
+ Hits         2428     2487      +59     
- Misses       1201     1209       +8     
+ Partials       32       31       -1     
Impacted Files Coverage Δ
aimmo-game/service.py 0.00% <ø> (ø)
example_project/settings.py 0.00% <ø> (ø)
example_project/test_settings.py 100.00% <ø> (ø)
game_frontend/src/components/Badge/badges.js 100.00% <ø> (ø)
game_frontend/src/components/ConsoleBar/index.js 100.00% <ø> (ø)
game_frontend/src/components/FindMeButton/index.js 100.00% <ø> (ø)
game_frontend/src/components/LogEntries/index.js 92.30% <ø> (ø)
...ame_frontend/src/components/NavigationBar/index.js 27.77% <ø> (ø)
...ame_frontend/src/components/RunCodeButton/index.js 97.29% <ø> (ø)
game_frontend/src/containers/IDEConsole/index.js 81.25% <ø> (+4.10%) ⬆️
... and 26 more

... and 2 files with indirect coverage changes

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@faucomte97 faucomte97 merged commit c9c7fa9 into master May 25, 2023
9 of 10 checks passed
@faucomte97 faucomte97 deleted the revert_badges_service_integration branch May 25, 2023 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kurono badges worksheet 2 - frontend
2 participants