Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove artefacts from Worksheet 1 #1775

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

cewei8483
Copy link
Collaborator

@cewei8483 cewei8483 commented Jun 1, 2023

Description

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have linked this PR to a ZenHub Issue.

This change is Reviewable

@cewei8483 cewei8483 linked an issue Jun 1, 2023 that may be closed by this pull request
1 task
Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cewei8483)

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Merging #1775 (ba69dac) into master (19a49f6) will increase coverage by 21.22%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #1775       +/-   ##
===========================================
+ Coverage   66.72%   87.95%   +21.22%     
===========================================
  Files         182       38      -144     
  Lines        3727     1046     -2681     
  Branches      264      109      -155     
===========================================
- Hits         2487      920     -1567     
+ Misses       1209      103     -1106     
+ Partials       31       23        -8     

see 146 files with indirect coverage changes

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @cewei8483)

@cewei8483 cewei8483 merged commit 3e3c44a into master Jun 6, 2023
8 checks passed
@cewei8483 cewei8483 deleted the 1688-remove-artefacts-from-worksheet-1 branch June 6, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove artefacts from Worksheet 1
2 participants