Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Try proper reverts on package upgrades #1803

Merged
merged 5 commits into from
Aug 11, 2023
Merged

Conversation

faucomte97
Copy link
Member

@faucomte97 faucomte97 commented Aug 11, 2023

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Aug 11, 2023
@faucomte97 faucomte97 changed the title Fix: Try proper reverts on package upgrades fix: Try proper reverts on package upgrades Aug 11, 2023
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #1803 (1bdd8cb) into master (9442398) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1803   +/-   ##
=======================================
  Coverage   67.50%   67.50%           
=======================================
  Files         184      184           
  Lines        3804     3804           
  Branches      264      264           
=======================================
  Hits         2568     2568           
  Misses       1208     1208           
  Partials       28       28           

@faucomte97 faucomte97 enabled auto-merge (squash) August 11, 2023 14:49
Copy link
Collaborator

@cewei8483 cewei8483 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@faucomte97 faucomte97 merged commit 9fd89f5 into master Aug 11, 2023
12 of 13 checks passed
faucomte97 added a commit that referenced this pull request Aug 14, 2023
faucomte97 added a commit that referenced this pull request Aug 14, 2023
* Revert "fix: Try downgrading greenlet"

This reverts commit 44c8898.

* Revert "fix: Try proper reverts on package upgrades (#1803)"

This reverts commit 9fd89f5.

* Revert "fix: Try reverting package upgrades (#1799)"

This reverts commit 086b9cb.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants