Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert worksheet ID type #1804

Merged
merged 2 commits into from
Aug 13, 2023
Merged

fix: Revert worksheet ID type #1804

merged 2 commits into from
Aug 13, 2023

Conversation

faucomte97
Copy link
Member

@faucomte97 faucomte97 commented Aug 13, 2023

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Aug 13, 2023
Copy link
Member Author

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @faucomte97)

@codecov
Copy link

codecov bot commented Aug 13, 2023

Codecov Report

Merging #1804 (0c0bf9f) into master (ee0fcba) will increase coverage by 0.05%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1804      +/-   ##
==========================================
+ Coverage   67.50%   67.56%   +0.05%     
==========================================
  Files         184      184              
  Lines        3804     3804              
  Branches      264      264              
==========================================
+ Hits         2568     2570       +2     
+ Misses       1208     1206       -2     
  Partials       28       28              
Files Changed Coverage Δ
aimmo/serializers.py 86.95% <50.00%> (+4.34%) ⬆️

@faucomte97 faucomte97 merged commit c951949 into master Aug 13, 2023
8 of 9 checks passed
@faucomte97 faucomte97 deleted the undo_worksheet_id_change branch August 13, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant