Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: track game load #1830

Merged
merged 20 commits into from
Nov 14, 2023
Merged

fix: track game load #1830

merged 20 commits into from
Nov 14, 2023

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Nov 13, 2023

This change is Reviewable

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

Copy link
Member

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

Copy link

codecov bot commented Nov 14, 2023

Codecov Report

Merging #1830 (7af2ac8) into master (5572800) will increase coverage by 0.02%.
The diff coverage is 80.00%.

❗ Current head 7af2ac8 differs from pull request most recent head 61acc01. Consider uploading reports for the commit 61acc01 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1830      +/-   ##
==========================================
+ Coverage   70.83%   70.85%   +0.02%     
==========================================
  Files         191      192       +1     
  Lines        3981     3991      +10     
  Branches      272      272              
==========================================
+ Hits         2820     2828       +8     
- Misses       1132     1134       +2     
  Partials       29       29              
Files Coverage Δ
aimmo/migrations/0037_worksheetusage_loaded_at.py 100.00% <100.00%> (ø)
aimmo/models.py 95.02% <100.00%> (+0.02%) ⬆️
aimmo/views.py 86.66% <60.00%> (-0.84%) ⬇️

@SKairinos SKairinos merged commit 166ca93 into master Nov 14, 2023
6 checks passed
@SKairinos SKairinos deleted the game_load branch November 14, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants