"Inline" the Atomic.t objects into the next fields of nodes

This effectively halves the length of the linked list of nodes and roughly doubles the thruput of the queue.
ocaml-multicore · Apr 2, 2024 · bd8eae0 · bd8eae0
1 parent d4d5c0b
commit bd8eae0
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/src_lockfree/michael_scott_queue_node.ml b/src_lockfree/michael_scott_queue_node.ml
@@ -3,10 +3,12 @@ module Atomic = Transparent_atomic
 type ('a, _) t =
   | Nil : ('a, [> `Nil ]) t
   | Next : {
-      next : ('a, [ `Nil | `Next ]) t Atomic.t;
+      mutable next : ('a, [ `Nil | `Next ]) t;
       mutable value : 'a;
     }
       -> ('a, [> `Next ]) t
 
-let[@inline] make value = Next { next = Atomic.make Nil; value }
-let[@inline] as_atomic (Next r : ('a, [ `Next ]) t) = r.next
+let[@inline] make value = Next { next = Nil; value }
+
+external as_atomic : ('a, [ `Next ]) t -> ('a, [ `Nil | `Next ]) t Atomic.t
+  = "%identity"