Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation error points to "Ocamlcommon" instead of "Ocaml_common" #101

Closed
ryco117 opened this issue Nov 19, 2019 · 1 comment
Closed

Comments

@ryco117
Copy link

ryco117 commented Nov 19, 2019

Hi, I'm trying to write my first ppx rewriter for Ocaml using ppxlib and when I tried to open Ast_mapper I was confronted with the error Accessing this module directly is deprecated, use Ocamlcommon.Ast_mapper instead, however it took me quite some searching to find that the module is actually called "Ocaml_common". This should be fixed.

(As an aside, a link to the most up-to-date documentation would be greatly appreciated as most of the PPX docs and tutorials are very old and inconsistent :/ )

@pitag-ha
Copy link
Member

pitag-ha commented Jun 1, 2021

I see that that's confusing. That error is raised by Ocaml_shadow from ocaml-compiler-libs. So I think we can't do anything about the wording from the ppxlib side. If you do see something, please feel free to reopen the issue.

@pitag-ha pitag-ha closed this as completed Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants