-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Context_free.Rule.attr*
#14
Comments
I'd like to give this a try in order to make my life easier with #61. I'm trying to understand what the scope of this actually is. My understanding so far is that we want to get rid of the These smart constructors appear to be called a single time, on all the registered generators at once. I'm not sure exactly what the new API should look like. I'm also guessing this is the occasion to leak a bit less about the internal types in |
I was thinking to completely remove them and make
Agreed. BTW, I remember that I tried this last year. My attempt is in the branch |
Hmm-- I'm working on a project that requires |
I know ppx_deriving allows this. It seems fine to add the same support in ppxlib. |
Does it, really? The API docs seem to indicate only support for |
This message helped me realize that the API docs for ppx_deriving were way out of date, I just updated them. The new docs, and it does mention the hooks to operate on module types (not modules), which were implemented in ocaml-ppx/ppx_deriving#94. |
Thanks for updating the docs! My project, however, requires operating on a module expression, which so it seems is not provided by |
These are only used for
[@@deriving ...]
and it's unlikely they'll ever be used for something else. Now that[@@deriving]
is part of ppxlib, I think removing them and specializing the implementation to only support[@@deriving ...]
would make the code simpler.The text was updated successfully, but these errors were encountered: