Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Printing outcomes buffer reveals too much information #312

Closed
adhameer opened this issue Sep 19, 2019 · 0 comments · Fixed by #481
Closed

Printing outcomes buffer reveals too much information #312

adhameer opened this issue Sep 19, 2019 · 0 comments · Fixed by #481
Labels
kind: enhancement Enhancement to an existing user-facing feature.

Comments

@adhameer
Copy link
Contributor

This is in relation to the merged PR #250, which added the outcomes buffer to the list of buffers to be printed when there is an error grading an exercise.

This is very useful for debugging, but when this buffer is printed on an instance of learn-ocaml that is exposed to students, it reveals far too much information: in particular it reveals the entire signature of the test.ml file for that exercise.

It would be useful to have this feature controlled by some sort of debug flag, and ideally to hide all this information about test.ml but still show the student some useful error message in the case of an error while grading their solution.

@EmileRolley EmileRolley added kind: enhancement Enhancement to an existing user-facing feature. kind: feature New user-facing feature. and removed kind: feature New user-facing feature. labels Jun 22, 2021
@AltGr AltGr closed this as completed in #481 Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: enhancement Enhancement to an existing user-facing feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants