Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support not logop in <dep-specification> #3653

Closed
xguerin opened this issue Jul 24, 2020 · 3 comments
Closed

Support not logop in <dep-specification> #3653

xguerin opened this issue Jul 24, 2020 · 3 comments

Comments

@xguerin
Copy link

xguerin commented Jul 24, 2020

Desired Behavior

Support negating statements in the dependency specification grammar. and and or are already supported in the logop rule, and the negation is supported in the opam file format.

Example

(depends
 (ocaml (or (and :with-test (>= 4.08.0))
            (and (not :with-test) (>= 4.02.0)))

Workaround

(depends
 (ocaml (or (and :with-test (>= 4.08.0))
            (and (= :with-test false) (>= 4.02.0)))
@rgrinberg
Copy link
Member

@avsm what do you think about this?

@avsm
Copy link
Member

avsm commented Jul 26, 2020

We should probably support the full opam grammar then; see also https://discuss.ocaml.org/t/compatibility-packages-conditional-dependencies-in-opam/6116/7.

I'd hoped to avoid the full complexity, but I think some of these formula are necessary these days.

@rgrinberg
Copy link
Member

@avsm in that case, are you ok with my proposal at #3497?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants