Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make (interface) optional in (dialect) #7776

Closed
aantron opened this issue May 22, 2023 · 2 comments · Fixed by #7757
Closed

Make (interface) optional in (dialect) #7776

aantron opened this issue May 22, 2023 · 2 comments · Fixed by #7757

Comments

@aantron
Copy link
Collaborator

aantron commented May 22, 2023

Desired Behavior

We would like to recommend Dune (dialect) for converting eml files to ML, which would be a major improvement (see aantron/dream#228). However, this currently requires boilerplate like this in dune-project:

(lang dune 2.0)

(dialect
 (name eml)
 (implementation
  (extension eml)
  (preprocess (run %{bin:dream_eml} --stdout %{input-file})))
 (interface
  (extension emli)
  (format (run cat))))

However, there are no emli files -- eml is concerned only with the expression language of ML. The (interface) stanza here is completely redundant. We would like to have something like...

Example

(lang dune 2.0)

(dialect
 (name eml)
 (implementation
  (extension eml)
  (preprocess (run %{bin:dream_eml} --stdout %{input-file}))))

...which should be much less confusing for Dream's users, and also would avoid any potential entanglements with actual emli files that may exist for some reason (it's cleaner).

@nojb
Copy link
Collaborator

nojb commented May 22, 2023

Is this the same issue that is addressed in #7757? And what with is the relation with #7777?

@emillon
Copy link
Collaborator

emillon commented May 22, 2023

Yes, I marked #7757 as fixing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants