Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hiding internal modules #99

Closed
andrewray opened this issue May 26, 2017 · 4 comments
Closed

Hiding internal modules #99

andrewray opened this issue May 26, 2017 · 4 comments

Comments

@andrewray
Copy link

Is there an appropriate way to hide a module that is used within a library, but shouldn't be exposed?

@ghost
Copy link

ghost commented May 26, 2017

If you don't use (wrapped false), then you can simply write a module with the name of the library and expose exactly what you want. Otherwise no.

I don't mind having an option to not install the .cmi for some specific modules. Currently jbuilder works the same whether things are installed or not, so this would need a bit of work to support properly. There would be something to do for wrapped libraries without an explicit interface as well, so that module aliases for these are not exposed externally.

In the meantime I suggest to simply use names that makes it clear that these modules are private.

@rgrinberg
Copy link
Member

@andrewray how come you closed this ticket? I think it's a reasonable request, if not a high priority.

@andrewray
Copy link
Author

@diml can decide if it should be open or not.

I find the wrapped by default argument, in general, convincing.

For the specific case of lwt, I wonder if we could do an install hack that just removed the offending cmis from lwt_unix.install. Or maybe just rename the modules to something crazy (XXX_internal_dont_use_XXX).

@bobot
Copy link
Collaborator

bobot commented May 28, 2017

#106 should do what you need. It's part of the features I need for using Jbuilder with Frama-C but I don't want to create too many MR at once.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants