Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C-c C-l fails for some reason #1548

Open
mimoo opened this issue Dec 21, 2022 · 7 comments
Open

C-c C-l fails for some reason #1548

mimoo opened this issue Dec 21, 2022 · 7 comments
Labels

Comments

@mimoo
Copy link

mimoo commented Dec 21, 2022

Hello hello,

I'm getting the following bottom buffer (that looks like it might be an error?) on emacs when trying to jump to definition:

Screenshot 2022-12-21 at 11 06 04 AM

(the offending code)

I've been trying to use emacs since vscode doesn't really work for me (see ocamllabs/vscode-ocaml-platform#1020), but it looks like I'm getting the same kind of jump to definition errors with emacs.

@voodoos
Copy link
Collaborator

voodoos commented Dec 22, 2022

That is unfortunate indeed. I will try to reproduce on my side.

Meanwhile, could you try to get the complete error log after enabing M-x merlin-enable-debug ?
Also a minimal reproduction would be great, but that might be difficult to get.

@voodoos
Copy link
Collaborator

voodoos commented Dec 22, 2022

I have not been able to reproduce so far: on either vscode of emacs it does jump do the declaration of the value (which is not what we are looking for but still better than the crash you witness).

@mimoo
Copy link
Author

mimoo commented Dec 22, 2022

do you know what I should do after M-x merlin-enable-debug? I get the same temporary buffer at the bottom when I do that.

@mimoo
Copy link
Author

mimoo commented Dec 22, 2022

OK I found a *merlin-log* buffer that had the info. Looks like a stack overflow: https://controlc.com/aa924e03

@voodoos
Copy link
Collaborator

voodoos commented Dec 26, 2022

Thank you. I don't have a file called src/lib/transaction_snark/test/zkapps_examples/thing/thing.ml so I cannot try to reproduce this specific SO.

@voodoos
Copy link
Collaborator

voodoos commented Dec 26, 2022

Just a blind guess: could you try to explicitely add the mina_wire_types library to the dune file of the concerned lib/executable, then rebuild and retry the query ?

@mimoo
Copy link
Author

mimoo commented Dec 28, 2022

oh the file is the same as https://github.com/MinaProtocol/mina/blob/develop/src/lib/transaction_snark/test/zkapps_examples/empty_update/empty_update.ml#L31

I tried again today and now it works, not sure what happened in between :|

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants