You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As you know, I've recently implemented a simple cache for Merlin's PPX phase. That cache needs to be explicitly enabled via the configuration.
Desired Behavior
It would be great if ocaml-lsp could enable the PPX phase cache iff the project doesn't use PPX dependencies (i.e. no preprocessor_deps field). So, iiuc, we need to distinguish two cases:
If the project doesn't have a .merlin-file, then ocaml-lsp needs to find out via a dune-rpc call whether the project uses PPX dependencies. If it doesn't, then ocaml-lsp should set the new use_ppx_cache field of config.merlin to true.
If the project has a .merlin-file, then the user (e.g. the user's build system, such as jenga) will take care of Merlin's config and ocaml-lsp doesn't need to do anything in particular (apart from updating the vendored Merlin).
Is that right? Does it sound good to you if we implement this?
The text was updated successfully, but these errors were encountered:
Hello @rgrinberg,
As you know, I've recently implemented a simple cache for Merlin's PPX phase. That cache needs to be explicitly enabled via the configuration.
Desired Behavior
It would be great if
ocaml-lsp
could enable the PPX phase cache iff the project doesn't use PPX dependencies (i.e. nopreprocessor_deps
field). So, iiuc, we need to distinguish two cases:If the project doesn't have a
.merlin
-file, thenocaml-lsp
needs to find out via adune-rpc
call whether the project uses PPX dependencies. If it doesn't, thenocaml-lsp
should set the newuse_ppx_cache
field ofconfig.merlin
totrue
.If the project has a
.merlin
-file, then the user (e.g. the user's build system, such asjenga
) will take care of Merlin's config andocaml-lsp
doesn't need to do anything in particular (apart from updating the vendored Merlin).Is that right? Does it sound good to you if we implement this?
The text was updated successfully, but these errors were encountered: