New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sentence on relationship between source files and modules #2034

Closed

cuihtlauac opened this issue Feb 8, 2024 · 1 comment · Fixed by #2047

Labels

bug documentation

Collaborator

cuihtlauac commented Feb 8, 2024 •

edited

Tutorial: Libraries with Dune
File: 1ms_02_dune.md, line 86

In OCaml, each source file is compiled into a module.

“Source file” is wrong, it should be ".ml file"
“compiled into a module” is flummox. Let's reuse words from section Modules and the file system of the manual

cuihtlauac added bug documentation labels

Contributor

The-Amoghavarsha commented Feb 10, 2024

“compiled into a module” is flummox. Let's reuse words from section Modules and the file system of the manual

What exactly should we use? Should we say, "In OCaml, each .ml file corresponds to a module."?

The-Amoghavarsha mentioned this issue

(doc) Improve wording in "Libraries with Dune" tutorial #2047

Merged

cuihtlauac closed this as completed in #2047

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment