Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unreadable documentation in dark-mode #2155

Closed
nikolaushuber opened this issue Mar 10, 2024 · 3 comments
Closed

Unreadable documentation in dark-mode #2155

nikolaushuber opened this issue Mar 10, 2024 · 3 comments

Comments

@nikolaushuber
Copy link

With the recent addition of a dark-mode for ocaml.org parts of the documentation for packages becomes basically unreadable (see attached screenshot). I have tried it on recent versions of Safari, Firefox, and Chrome, all give the same result.

I didn't see an option on the webpage itself to toggle between light and dark mode (did I miss that somewhere?), so currently the only possibility is to change the preference settings of the operating system (I am working on a Mac, maybe this is different for other OSs?).

Screenshot 2024-03-10 at 16 54 26
@sabine
Copy link
Collaborator

sabine commented Mar 10, 2024

Doh, sorry about that, will revert until that is resolved.

@sabine
Copy link
Collaborator

sabine commented Mar 10, 2024

Here's some preliminary adjustments to make this work:

https://github.com/sabine/ocaml.org/tree/dark_mode_package_docs

This is not done yet, but if I don't manage to do this by tomorrow, someone else could step in and finish this.

@sabine
Copy link
Collaborator

sabine commented Mar 11, 2024

Addressed for now by #2159.

@sabine sabine closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants