Reintroduce caml_final_do_calls_exn #11039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(cc @sadiqj) |
|
Regarding the gotos, here I advocated in favour of a systematic style that clearly separates the normal path from the error path: #8997 (comment). A systematic style makes it easier to read and evolve code (you can just ignore the error path). |
Reintroduce fix to minor bugs in Gc.{major,full_major,compact}
sadiqj
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintroduce fix to minor bugs in
Gc.{major,full_major,compact}.This essentially completes the side-by-side review of
runtime/finalise.c, a task of #10915.