Fix "ocamlrun -b" crash #11824
Merged
Fix "ocamlrun -b" crash #11824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shindere
approved these changes
Dec 19, 2022
|
I am convinced that the code is correct.
I quickly went through `caml_record_backtraces` out of curiosity and
found it non trivial to read but this has nothing to do withhtis PR
which I really thinkn is correct.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code paths for
ocamlrun -bandOCAMLRUNPARAM=b ocamlrun ...have currently diverged in such way that the former is currently segfaulting.The issue is that
ocamlrun -bcallscaml_record_backtracesbefore domains are fully initialized, which results in a crash oncecaml_record_backtracestry to accessCaml_state.This PR fixes the divergence and the crash by setting
caml_params<-backtrace_enabledto true in both code paths.