Simplify calls to caml_int_compare (and similar functions) (was #1809) #12181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smuenzel
changed the title
smuenzel
force-pushed
the
optim-comparison
branch
3 times, most recently
from
f7beba2
to
f87b07a
Compare
smuenzel
force-pushed
the
optim-comparison
branch
from
f87b07a
to
fd8fa16
Compare
|
Does anyone have thoughts on this PR? A review was already done in #1809 |
|
@lthls could you by chance do another round of review on this? |
lthls
approved these changes
Oct 23, 2023
|
Thanks @lthls. I will follow up later and check if the case with zero first occurs in the wild and submit a follow-up PR if it does. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase #1809 to account for the new comparison primitive.
Also change the tests to force generation of assembly, so we can compare the output (which I did for amd64, and the simplification indeed works).
FYI @xclerc, @lthls