-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix a typo in inheritance error message. #12199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the unrelated suggestion. I think this message could be clearer by stating why it is fired:
Error: This inheritance does not override any methods or instance variables
but is marked as overriding with `!`.
An hint could be added to suggest to remove the !
but I'm worried it would be wrong in many cases (where the intended solution would be to add a method).
Thanks for the suggestion ! I agree that it is better to be more explicit with such infrequent error messages. |
82b3c8b
to
38bfc61
Compare
Updated with the new quoting style. @Julow are you fine with the current error message? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved on @Julow's behalf.
38bfc61
to
e25b5ab
Compare
Currently,
emits the following error message:
This PR fixes the missing
or
and plural betweenmethod
andinstance variable
: