domain_create: deliver an Out_of_memory exception if malloc fails #12268
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dra27
approved these changes
Jun 9, 2023
This is what we do elsewhere in the runtime if a malloc fails, and it helps distinguish the sort of resource exhaustion a domain create is seeing (thread limits _vs_ memory limits) Spotted during review for ocaml#12263
avsm
force-pushed
the
oom-on-domain-create-fail
branch
from
cabe2da
to
64ff653
Compare
|
Thanks @dra27; rebased and Changes entry added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what we do elsewhere in the runtime if a malloc fails, and it helps distinguish the sort of resource exhaustion a domain create is seeing (thread limits vs memory limits)
Spotted during review for #12263