-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 32-bit targets from X86_proc.system #12447
Conversation
7f78ccc
to
16b61ba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solaris and Haiku are both 64-bit, so don't want to be removed (I'm afraid that means the code simplification goes). FWIW, a follow-on to #12405 is to move X86_proc.system
into ocamlcommon and use it instead of strings throughout the distribution.
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
16b61ba
to
05fdf91
Compare
Thank you for your suggestions, @dra27! I have updated the patch. |
Sounds reasonable, but I have not yet understand how |
Well, so, does removing them at this moment not make sense as they will be revived for a common component used by both the byte code compiler and the native code compiler? |
Yes, indeed - sorry, I didn't mean to imply it had to be done here 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the edits - even if the type does end up moved into ocamlcommon, I think this is a nice clean-up to do now, especially as the system values it's matching for some of those 32-bit architectures will wrong when #12405 goes in.
Thank you! |
This cleans up
X86_proc
a bit as 32-bit targets are no longer supported byasmcomp
.