Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 32-bit targets from X86_proc.system #12447

Merged
merged 1 commit into from
Aug 22, 2023

Conversation

omasanori
Copy link
Contributor

This cleans up X86_proc a bit as 32-bit targets are no longer supported by asmcomp.

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solaris and Haiku are both 64-bit, so don't want to be removed (I'm afraid that means the code simplification goes). FWIW, a follow-on to #12405 is to move X86_proc.system into ocamlcommon and use it instead of strings throughout the distribution.

asmcomp/x86_proc.ml Show resolved Hide resolved
asmcomp/x86_proc.ml Show resolved Hide resolved
Signed-off-by: Masanori Ogino <167209+omasanori@users.noreply.github.com>
@omasanori
Copy link
Contributor Author

Thank you for your suggestions, @dra27! I have updated the patch.

@omasanori
Copy link
Contributor Author

FWIW, a follow-on to #12405 is to move X86_proc.system into ocamlcommon and use it instead of strings throughout the distribution.

Sounds reasonable, but I have not yet understand how compilerlibs/Makefile.compilerlibs works. Can I postpone it?

@omasanori
Copy link
Contributor Author

Well, so, does removing them at this moment not make sense as they will be revived for a common component used by both the byte code compiler and the native code compiler?

@dra27
Copy link
Member

dra27 commented Aug 1, 2023

Can I postpone it?

Yes, indeed - sorry, I didn't mean to imply it had to be done here 🙂

Copy link
Member

@dra27 dra27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the edits - even if the type does end up moved into ocamlcommon, I think this is a nice clean-up to do now, especially as the system values it's matching for some of those 32-bit architectures will wrong when #12405 goes in.

@dra27 dra27 merged commit 6ca0dfb into ocaml:trunk Aug 22, 2023
9 checks passed
@dra27
Copy link
Member

dra27 commented Aug 22, 2023

Thank you!

@omasanori omasanori deleted the asmcomp-x86-simplify branch August 22, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants