Add a closing event for when EV_MAJOR_EPHE_MARK is complete
#12583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gasche
approved these changes
Sep 19, 2023
|
This probably wants a Changes entry ("Bug fixes"?) for future users of old versions of the language that will want to know whether/when the bug that they observe has been fixed in more recent versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a minor fix to add a missing closing runtime event for
EV_MAJOR_EPHE_MARK. I discovered this while debugging tarides/runtime_events_tools#20. I gave this a spin witholly traceon one of the ephemeron tests (ephe_test.ml) in the testsuite - it appears this patch has fixed this non-terminating event.The trace produced by 5.1.0 rendered on ui.perfetto.dev:
The trace produced by 5.1.0 + this PR:
Please note that I ran the tests on 5.1.0 along with the commit in this PR. This was necessary because 'olly' depends on ppx, and support for ppx on the trunk is not available yet (afaict).