make -C testsuite parallel always runs tests in subdirs
#12744
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nojb
reviewed
Nov 15, 2023
| if [ -d $$dir ]; then \ | ||
| $(MAKE) exec-one DIR=$$dir; \ | ||
| fi; \ | ||
| done |
There was a problem hiding this comment.
Can't we use $(ocamltest) -find-test-dirs $(DIR) here, like we do in the new-without-report (called by make all) target?
There was a problem hiding this comment.
I've made this change. Thanks -- this makes the makefile less complicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it so
make -C testsuite parallelruns all tests in all (recursive) subdirectories oftestsuite/tests. Previously, the test runner wouldn't descend recursively into subdirectories if the parent directory had any tests at all. This meant that one test wasn't being run bymake -C testsuite paralleland so wasn't being run in CI (e.g. this recent run).That test:
testsuite/tests/tool-toplevel/known-bugs/broken_rec_in_show.mlPrior to this PR, that test would not be run by either of these invocations:
make -C testsuite parallelmake -C testsuite one DIR=tests/tool-toplevelNow, both of those invocations will run that test. You can verify this yourself in the CI logs, or by modifying the test locally and confirming that the error is raised by those invocations.
An alternative approach: moving that test up one level of directory structure. This PR's approach is preventative and helps avoid this mistake in the future.