Move all installable headers in caml/ sub-directories
#12764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"No problem." |
MisterDA
force-pushed
the
headers-caml-subdir
branch
from
9a76650
to
6e4629a
Compare
dra27
approved these changes
Dec 18, 2023
C11 defines the `<threads.h>` header. Within the current tests, the
`systhreads/threads.h` header happens to be in the include path, and
thus has higher priority than the standard header, which cannot be
used. Namespacing fixes this problem.
In addition, there were discrepancies between on the one hand C
files (`.c`, `.h`) in internal code and tests, expecting
#include "unixsupport.h"
and on the other hand external code, (also documented in the manual),
expecting
#include <caml/unixsupport.h>
Moving the location of the headers allows to properly namespace them:
#include "caml/unixsupport.h"
This also helps highlighting within the code of a library which header
is installed.
MisterDA
force-pushed
the
headers-caml-subdir
branch
from
6e4629a
to
d02ad4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C11 defines the
<threads.h>header. Within the current tests, thesysthreads/threads.hheader happens to be in the include path, and thus has higher priority than the standard header, which cannot be used. Namespacing fixes this problem.In addition, there were discrepancies between on the one hand C files (
.c,.h) in internal code and tests, expectingand on the other hand external code, (also documented in the manual), expecting
Moving the location of the headers allows to properly namespace them:
This also helps highlighting within the code of a library which header is installed.
There are no cases where it would make sense to replace double quotes includes with angle brackets.
Traditionally this sub-directory where installable headers can be found is named
include/.