Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ThreadSanitizer support for FreeBSD/amd64 #12809

Merged
merged 2 commits into from
Dec 7, 2023
Merged

ThreadSanitizer support for FreeBSD/amd64 #12809

merged 2 commits into from
Dec 7, 2023

Conversation

dustanddreams
Copy link
Contributor

Not much to say, this was almost piece of cake.

Things to consider:

  • the default compiler in FreeBSD is cc, which is clang, so match on ocaml_cv_cc_vendor rather than cc_basename to decide whether the compiler is TSan-capable.
  • this should work on FreeBSD 13.2 and FreeBSD 14.0, but applying errata FreeBSD-EN-23:15 is required on both versions for TSan binaries to behave correctly (binary patches are available, as documented in the errata notice, so this is easy to apply). I don't know whether we should document this requirement - there will be FreeBSD releases 13.3 and 14.1 eventually, which will not require this step.
  • this has only been tested on FreeBSD 14.0. (the configure changes have however been also tested under Linux to confirm they don't break anything there).

gasche
gasche reviewed Dec 7, 2023
View reviewed changes
Changes Outdated
@@ -198,6 +198,9 @@ Working version
- #12735: Store both ends of the stack chain in continuations
(Leo White, review by Miod Vallat and KC Sivaramakrishnan)

- #xxxxx: Add ThreadSanitizer support to FreeBSD/amd64
(Miod Vallat, review by TBD)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be updated

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@gasche gasche added the merge-me label Dec 7, 2023
@kayceesrk kayceesrk merged commit 4fb079c into ocaml:trunk Dec 7, 2023
10 checks passed
@dustanddreams dustanddreams deleted the tsan_freebsd_amd64_tsan branch December 7, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gasche gasche gasche approved these changes

Assignees
No one assigned
Labels
merge-me
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dustanddreams @gasche @kayceesrk