Fix s390x stack reallocation code in PIC mode #12831
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dustanddreams
approved these changes
Dec 15, 2023
|
Did you check for other instances of this issue? |
I did; this was the only non-wrapped call instruction in the s390x code generator. |
gasche
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Approved on @dustanddreams' behalf. Thanks both for the quick fix and quick review!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
emit_callfunction adds a@PLTsuffix in PIC mode, if it is missing the dynamic linker may not fix the reference appropriately.Fixes #12829.