show non-generalizable type parameters in type definitions #12837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octachron
reviewed
Dec 18, 2023
| @@ -710,6 +710,10 @@ Working version | |||
| - #12831: Fix call to caml_call_realloc_stack for s390x in PIC mode | |||
| (Vincent Laviron, report by Jerry James, review by Miod Vallat) | |||
|
|
|||
| * #12837: Show non-generalizable type parameters in type definitions | |||
There was a problem hiding this comment.
This change is only breaking the compiler API, I think it would be clearer for most people to mark it as non-breaking.
There was a problem hiding this comment.
Indeed, I don't know of people in the wild who depend on the outcometree type definition -- in any sort of supported way.
garrigue
force-pushed
the
show_nongen_params
branch
from
1bbf215
to
1b735a5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Error message used to be confusing, as it looked like there were two different variables.
Note that we are changing outcometree.mli, so this is a breaking change.