-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.2.0~alpha1: Issues with (x : Subtype.t list :> Type.t list) in presence of multiple destructive substitutions #12982
Comments
I can't make a better guess than you did, so I would just try bisecting |
@Octachron made some progress debugging this in the meantime and it seems to be related to the preview of ppxlib we are using. Either one of us will close this if it's confirmed to be ppxlib-only issue |
This seems indeed increasingly likely to be a ppxlib issue. Typically, my reproduction case at https://github.com/Octachron/bug-reproduction-archives/tree/main/ppxlib_and_include fails with the reported error whenever a ppxlib-based ppx is used (even for an identity ppx). |
mmh, that's weird though, your example doesn't use any ppxlib feature other than the driver. |
oh nevermind i read the |
I've just tried the main branch of ppxlib and it works just fine there if that was what you were thinking. However I also managed to reduce @Octachron's test case even more: Octachron/bug-reproduction-archives#1 I'll close this issue to avoid further noise. The ppxlib maintainers have been notified. |
When testing 5.2.0~alpha1 against opam-repository i saw these two Janestreet packages that compiles just fine on 5.1 but fails with that 5.2 release:
We've tried to reproduce in a smaller test-case with @Octachron but without success.
Does anyone know what type of change could be responsible for this type of failure?
The code for both of those can be seen in:
Both codes seem to be pretty similar with a heavy use of includes, module types and destructive type substitutions
The text was updated successfully, but these errors were encountered: