Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamldoc super/subscript style is an unreadable 4 pixels #6310

Closed
vicuna opened this issue Jan 28, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@vicuna
Copy link

commented Jan 28, 2014

Original bug ID: 6310
Reporter: @avsm
Assigned to: @zoggy
Status: closed (set by @xavierleroy on 2015-12-11T18:25:40Z)
Resolution: fixed
Priority: low
Severity: tweak
Version: 4.01.0
Fixed in version: 4.02.0+dev
Category: ocamldoc
Tags: patch

Bug description

The superscript and subscript classes for ocamldoc are set to 4 pixels, which essentially makes them invisible on a modern browser. For example, the "Random.int" documentation appears to state that the bound should be from 0 to 2 here: http://caml.inria.fr/pub/docs/manual-ocaml/libref/Random.html

The below diff tweaks it to a more reasonable size:

diff --git a/ocamldoc/generators/odoc_literate.ml b/ocamldoc/generators/odoc_literate.ml
index 6a1e078..38545f9 100644
--- a/ocamldoc/generators/odoc_literate.ml
+++ b/ocamldoc/generators/odoc_literate.ml
@@ -127,8 +127,8 @@ class html =
"a:active {color : Red; text-decoration : underline; }" ;
".keyword { font-weight : bold ; color : Red }" ;
".keywordsign { color : #C04600 }" ;

  •      ".superscript { font-size : 4 }" ;
    
  •      ".subscript { font-size : 4 }" ;
    
  •      ".superscript { font-size : 0.6em }" ;
    
  •      ".subscript { font-size : 0.6em }" ;
         ".comment { color : Green }" ;
         ".constructor { color : Blue }" ;
         ".type { color : #5C6585 }" ;
    
@vicuna

This comment has been minimized.

Copy link
Author

commented Jan 28, 2014

Comment author: @gasche

Thanks, applied in trunk.

@vicuna vicuna closed this Dec 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.