Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asmlink should also reset ccobjs/ccopts #7738

Closed
vicuna opened this Issue Feb 21, 2018 · 3 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented Feb 21, 2018

Original bug ID: 7738
Reporter: @rixed
Assigned to: @gasche
Status: resolved (set by @gasche on 2018-02-21T10:45:02Z)
Resolution: fixed
Priority: normal
Severity: minor
Version: 4.06.1
Fixed in version: 4.07.0+dev/beta2/rc1/rc2
Category: compiler driver

Bug description

When using the compiler-libs in a program and trying to compile several source codes I noticed some options to gcc accumulated from one compilation to the next, despite I've tried to cleaned as many global variables as I could, including via Asmlink.reset().

Problem seems to be that the aforementioned reset function does not clean lib_ccobjs or lib_ccopts.

A quick test suggest that cleaning those does fix my issue without introducing any bug I could notice.

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Feb 21, 2018

Comment author: @gasche

These variables are reset by Bytelibrarian.reset and Bytelink.reset, so indeed it seems correct to reset them in asmcomp/ modules that set them. Would you care to submit a Pull Request?

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Feb 21, 2018

Comment author: @rixed

Cf. #1624

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented Feb 21, 2018

Comment author: @gasche

The soon-to-be-merged PR resolves the issue. Thanks!

@vicuna vicuna closed this Feb 21, 2018

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.