Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocamldep does not handle SEMISEMI correctly #7793

Closed
vicuna opened this Issue May 6, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@vicuna
Copy link
Collaborator

vicuna commented May 6, 2018

Original bug ID: 7793
Reporter: @hhugo
Assigned to: @nojb
Status: closed (set by @nojb on 2018-05-23T23:10:02Z)
Resolution: fixed
Priority: normal
Severity: minor
Category: tools (ocaml{lex,yacc,dep,debug,...})
Monitored by: @nojb

Bug description

The following program is accepted by the ocaml compiler but not by ocamldep

;;

;;2

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented May 6, 2018

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented May 6, 2018

Comment author: @nojb

At first sight it seems the difference is that ocamldep parses .ml files using Parse.use_file and the compiler uses Parse.implementation. For .mli files both use Parse.interface.

Anyone remembers the reason for the different handling of .ml files?

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented May 6, 2018

Comment author: @nojb

#1766

@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented May 7, 2018

Comment author: @hhugo

commit 89077f5
Author: Damien Doligez <damien.doligez-inria.fr>
Date: Fri Aug 10 07:19:12 2012 +0000

Make ocamldep ignore toplevel directives in .ml files, as it did before
commit 12769.
@vicuna

This comment has been minimized.

Copy link
Collaborator Author

vicuna commented May 23, 2018

Comment author: @hhugo

GPR merged. This can be closed

@vicuna vicuna closed this May 23, 2018

@vicuna vicuna added the tools label Mar 14, 2019

@vicuna vicuna added the bug label Mar 20, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.