Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sudo:false in .travis.yml #9402

Merged
merged 2 commits into from
Mar 28, 2020
Merged

Remove sudo:false in .travis.yml #9402

merged 2 commits into from
Mar 28, 2020

Conversation

y-yu
Copy link
Contributor

@y-yu y-yu commented Mar 28, 2020

@dra27
Copy link
Member

dra27 commented Mar 28, 2020

Thanks for the change - without lessening it, we don't normally do Changes entries for CI updates - did you only push that second commit to satisfy the Travis test?

@dra27 dra27 merged commit 49d0580 into ocaml:trunk Mar 28, 2020
@dra27
Copy link
Member

dra27 commented Mar 28, 2020

Thanks!

@y-yu
Copy link
Contributor Author

y-yu commented Mar 29, 2020

@dra27

Thank you.

we don't normally do Changes entries for CI updates

Sorry 🙇 I just thought all CI tests should pass so I was planning to remove the Changes commit (a53c051) if such a changing wouldn't be written in Changes.... So I don't mind if you will remove my entry in Changes.

@y-yu y-yu deleted the patch-1 branch March 29, 2020 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants