ocamldoc: fix the printing of (::) #9427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawaramin
approved these changes
Apr 6, 2020
ocamldoc/odoc_sig.ml
Outdated
| | "::" -> | ||
| (* The only infix constructor is always printed (::) *) | ||
| "(::)" | ||
| | s -> s in |
There was a problem hiding this comment.
Slight formatting quibble, it looks like in is usually on its own line for multi-line bindings...
There was a problem hiding this comment.
Indeed, and it's the style used right above this let-binding.
Suggested change
| | s -> s in | |
| | s -> s | |
| in |
damiendoligez
approved these changes
Sep 4, 2020
ocamldoc/odoc_sig.ml
Outdated
| | "::" -> | ||
| (* The only infix constructor is always printed (::) *) | ||
| "(::)" | ||
| | s -> s in |
There was a problem hiding this comment.
Indeed, and it's the style used right above this let-binding.
Suggested change
| | s -> s in | |
| | s -> s | |
| in |
Octachron
force-pushed
the
ocamldoc_list_syntax
branch
from
ccb8a21
to
1393a37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
is printed by ocamldoc as
This small PR fixes this issue in all ocamldoc backends by using directly
(::)in the ocamldoc description of variant constructors.Closes #9421 .
(There is no parentheses needed for the four other non-UIDENT constructors: true, false, [] and () )