Export, document, and use Unix._exit #9914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a wrapper around the _exit system call. It has been implemented in otherlibs/unix/exit.c for a long time but never exported. This commit exports and documents it as `Unix._exit`. The Unix implementation of `establish_server` is changed to use `_exit` and to have gender-neutral comments. A test was added to check that OCaml finalization actions are not performed.
ivg
approved these changes
Sep 14, 2020
|
The code looks nice and correct to me and I find the test especially
elegantand simple.
Given that the PR adds a funciton to a public module, it seems it is
worth a Changes entry.
|
shindere
approved these changes
Sep 14, 2020
dra27
reviewed
Sep 14, 2020
|
|
||
| let _ = | ||
| at_exit (fun () -> print_string "B\n"; flush stdout); | ||
| print_string "A\n"; (* don't flush *) |
There was a problem hiding this comment.
I thought that the channel I/O doesn't guarantee to flush without an explicit instruction, but isn't it (or a future implementation) at liberty to flush if it wants to? Isn't the test sufficient without this line anyhow?
There was a problem hiding this comment.
Yes, this test relies on a particular implementation of I/O channels w.r.t. flushing, but said behavior hasn't changed since Caml Light, IIRC, so the test should be OK. I'll fix it later if it causes problems.
|
@ivg - |
|
Beware that |
|
Good point - and therefore that #9745 wants to go in first! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a wrapper around the
_exitsystem call. It has been implemented in otherlibs/unix/exit.c for a long time but never exported. This PR exports and documents it asUnix._exit.The Unix implementation of
establish_serveris changed to use_exitand to have gender-neutral comments.A test was added to check that OCaml finalization actions are not performed.