Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package names containing consecutive + characters are not technically valid (and should be) #59

Open
dra27 opened this issue Feb 15, 2024 · 0 comments

Comments

@dra27
Copy link
Member

dra27 commented Feb 15, 2024

ocaml/opam#2724 overhauled the handling of package atoms, but there appears to have been a slight error with the handling of the + character. This wouldn't have been a detectable issue in 2016, and I expect the primary motivation was the single + used in versions for variants, but we now have conf-c++ and conf-g++ in opam-repository, and it's not possible to refer to their boolean variables in the natural syntax:

 "i686-gcc-g++" {conf-mingw-w64-g++-i686:installed}

results in

    error  2: File format error at line 27, column 40: '+' is not a valid token

I think it should be sufficient simply to allow one or more + characters in the ident regular expression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant