Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

+ sqlgg 20231201 #24884

Merged
merged 9 commits into from
Jun 24, 2024
Merged

+ sqlgg 20231201 #24884

merged 9 commits into from
Jun 24, 2024

Conversation

ygrek
Copy link
Contributor

@ygrek ygrek commented Dec 1, 2023

No description provided.

Copy link
Collaborator

@haochenx haochenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you look into the lower bound check failures like the following?

packages/sqlgg/sqlgg.20231201/opam Outdated Show resolved Hide resolved
packages/sqlgg/sqlgg.20231201/opam Outdated Show resolved Hide resolved
Co-authored-by: Haochen M. Kotoi-Xie <hx@kxc.inc>
@mseri
Copy link
Member

mseri commented Dec 18, 2023

@ygrek can you make the fixes also upstream?
There is a failure that I still don't understand in https://github.com/ygrek/sqlgg/blob/master/src/gen_caml.ml#L430

# File "src/gen_caml.ml", line 438, characters 6-10:
# 438 |     | None -> exec
#             ^^^^
# Error: This pattern should not be a constructor, the expected type is
#        Sqlgg.Sql.param_id

@ygrek
Copy link
Contributor Author

ygrek commented Jun 7, 2024

the reason is ygrek/ocaml-extlib@4ef8bc2
ie lower bound for extlib should be 1.7.8
pushed all changes upstream in ygrek/sqlgg@012fb15
thanks!

Co-authored-by: Shon Feder <shon.feder@gmail.com>
@mseri mseri merged commit a5f92bf into ocaml:master Jun 24, 2024
3 checks passed
@mseri
Copy link
Member

mseri commented Jun 24, 2024

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants