Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog update and check #4181

Closed
rjbou opened this issue May 6, 2020 · 1 comment
Closed

Changelog update and check #4181

rjbou opened this issue May 6, 2020 · 1 comment

Comments

@rjbou
Copy link
Collaborator

rjbou commented May 6, 2020

PR #4180 added a working changelog file master_changes.md and a github action to check that it is updated for each prs, if modifications are not whitelisted (infra/internal files, e.g. travis, readme, etc.).
It is a first step for minimal updates and checks.

(from #4180 (comment))

I dissociate the current changelog from the release one because they don't have the same purpose (neither the same format). The master_changes.md files contains all updates, so it contains almost all PRs (unless it's infra/CI ones). It is draft material to construct the release changelog and the release note.
The current changelog check/update is meant to evolve, to facilitate user pr process, e.g. for small prs, when PR title & changelog update are exactly the same, using a comment directive, an action to update automatically the PR.

On another hand, @dra27 began a same purpose project for ocaml repository, based on labels to dismiss some PRs check.

@dra27
Copy link
Member

dra27 commented Jul 8, 2021

I think your master_changes.md check is working fine 🙂

@dra27 dra27 closed this as completed Jul 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants