Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating "features" #4521

Open
emillon opened this issue Feb 3, 2021 · 2 comments
Open

Deprecating "features" #4521

emillon opened this issue Feb 3, 2021 · 2 comments
Projects

Comments

@emillon
Copy link
Contributor

emillon commented Feb 3, 2021

The "features" field is accepted in opam files:

(** Contents of the 'features' field *)
val features: t -> (OpamVariable.t * filtered_formula * string) list

It is documented as an experiment but it looks like the feature was never used. Something similar is likely to be useful with package variables but it looks like this first implementation can be deprecated in 2.1 or 2.2.

@dra27 dra27 added this to To do in Opam 2.2.0 via automation Jun 25, 2021
@dra27 dra27 added this to the 2.2.0~alpha milestone Jun 25, 2021
@dra27
Copy link
Member

dra27 commented Jun 25, 2021

See #4519 (comment)

@dra27 dra27 moved this from To do to opam file updates in Opam 2.2.0 Jul 15, 2021
@AltGr
Copy link
Member

AltGr commented Jan 4, 2022

This is different from libraries and syntax in that, although unused, it is documented and doesn't do absolutely nothing.
I'd say we can keep it (with the experimental flag) until we have an actual implementation for package variables.

@dra27 dra27 added this to To do in Opam 2.3 via automation May 17, 2022
@dra27 dra27 removed this from To do: opam file updates in Opam 2.2.0 May 17, 2022
@dra27 dra27 removed this from the 2.2.0~alpha milestone May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Opam 2.3
  
To do
Development

No branches or pull requests

3 participants