Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce opam-root-version #4636

Closed
dra27 opened this issue Apr 16, 2021 · 0 comments · Fixed by #4638 or #4742
Closed

Introduce opam-root-version #4636

dra27 opened this issue Apr 16, 2021 · 0 comments · Fixed by #4638 or #4742
Assignees
Projects
Milestone

Comments

@dra27
Copy link
Member

dra27 commented Apr 16, 2021

Discussed on 1 Apr, introduce opam-root-version for the root and switch config files which is checked for taking out write locks. opam-version is checked for taking out read locks. So after root upgrade, $OPAMROOT/config would contain:

opam-version: "2.0"
opam-root-version: "2.1"

opam-state 2.0.x should be updated to internally recognise opam-root-version (i.e. no change in API in OpamFile) and ignore fields it doesn't recognise. The changes we've made for 2.1 mean that it should "just work" to have readable roots to 2.0.

As always, a given version of opam would never attempt to read a file with opam-version greater than itself.

@dra27 dra27 added this to the 2.0.9 milestone Apr 16, 2021
@dra27 dra27 added this to To do in Opam 2.1.x via automation Apr 16, 2021
@rjbou rjbou moved this from To do to In Progress in Opam 2.1.x Apr 21, 2021
@dra27 dra27 mentioned this issue May 5, 2021
2 tasks
Opam 2.1.x automation moved this from In Progress to Done May 28, 2021
@dra27 dra27 linked a pull request Jul 26, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Opam 2.1.x
  
Done
2 participants