Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Syntax for avoiding spdx warning 62 ? #4862

Closed
dbuenzli opened this issue Oct 9, 2021 · 7 comments · Fixed by #4863
Closed

Syntax for avoiding spdx warning 62 ? #4862

dbuenzli opened this issue Oct 9, 2021 · 7 comments · Fixed by #4863

Comments

@dbuenzli
Copy link
Contributor

dbuenzli commented Oct 9, 2021

Unless I missed it*, it seems there is no syntax to specify a license identifier for licenses that do not fall under the SPDX ones.

Not everything out there fits into SPDX identifiers; if only non-libre software. Here's an example:

/Users/dbuenzli/sync/repos/odig/opam: Warnings.
  warning 62: License doesn't adhere to the SPDX standard, see https://spdx.org/licenses/:
 "ParaType-Free-Font-License", "DejaVu-fonts"

For example ParaType-Free-Font-License is what is used by debian in the corresponding font package. DejaVu-fonts is my invention, it's a complicated set of licenses (I suspect the debian package specification for that one is underspecified); it just means go check it out if you need to.

If there is no established convention, maybe a not-spdx: prefix ? (Though I highly dislike the spdx jargon).

*: I have to admit I have difficulties to navigate the spdx standard and website which it seems has been taken over by enterprisy bureaucrats.

@kit-ty-kate
Copy link
Member

kit-ty-kate commented Oct 9, 2021

Custom license names are supported in the SPDX standard through: LicenseRef-your-custom-name-here
In your case this should be:

license: "LicenseRef-ParaType-Free-Font-License AND LicenseRef-DejaVu-fonts"

(or OR instead of AND depending on what the license actually is)
See #4768 for more information.

Side note: The full SPDX standard (see PR above) is only supported on master (2.2.0). Hopefully it will be released soon enough.

@dbuenzli
Copy link
Contributor Author

dbuenzli commented Oct 9, 2021

Thanks but I tried to figure out that for at least half an hour and didn't succeed. Could you maybe update the opam manual with more precise information ? A good friend should not send you to visit the spdx website like the warning does.

@kit-ty-kate
Copy link
Member

kit-ty-kate commented Oct 9, 2021

Yes I was already doing it in #4863 ^^

@dbuenzli
Copy link
Contributor Author

dbuenzli commented Oct 9, 2021

Also is there an implicit AND or OR between the licenses in the license: field ?

@kit-ty-kate
Copy link
Member

mmh, ah yeah we could update the warning too. Could you do a PR for that if you have some time? I would not be sure how to formulate it

@dbuenzli
Copy link
Contributor Author

dbuenzli commented Oct 9, 2021

Honestly I rather not get into a DSL to specify my licenses. I think opam should simply attribute a semantics and that semantics should be AND.

@kit-ty-kate
Copy link
Member

Also is there an implicit AND or OR between the licenses in the license: field ?

My guess is that it mostly mean AND but I don't think it's defined anywhere so anyone can use it as they wish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants