Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitconfig color.ui = always breaks patches #4883

Closed
Blaisorblade opened this issue Nov 3, 2021 · 1 comment · Fixed by #4884
Closed

gitconfig color.ui = always breaks patches #4883

Blaisorblade opened this issue Nov 3, 2021 · 1 comment · Fixed by #4884
Projects
Milestone

Comments

@Blaisorblade
Copy link
Contributor

With git's color.ui set to always, I get the following errors:

[ERROR] Could not update repository "bb-overlay-fork": "/usr/local/bin/patch -p1 -i /Users/pgiarrusso/.opam/log/processed-patch-58446-70a526" exited with code 2 "/usr/local/bin/patch: **** Only garbage was found in the patch input."
[bb-overlay] synchronised from git+https://github.com/Blaisorblade/opam-overlay.git
[ERROR] Could not update repository "bb-overlay": "/usr/local/bin/patch -p1 -i /Users/pgiarrusso/.opam/log/processed-patch-58446-e80101" exited with code 2 "/usr/local/bin/patch: **** Only garbage was found in the patch input."
[iris-dev] synchronised from git+https://gitlab.mpi-sws.org/iris/opam.git
[ERROR] Could not update repository "iris-dev": "/usr/local/bin/patch -p1 -i /Users/pgiarrusso/.opam/log/processed-patch-58446-8b8e2c" exited with code 2 "/usr/local/bin/patch: **** Only garbage was found in the patch input."

Maybe opam needs to override color.ui git settings, like it does (IIRC) for a few others (e.g. #3788)?

Tested on opam 2.0.8.

@rjbou
Copy link
Collaborator

rjbou commented Nov 3, 2021

Can you check that #4884 fixes the issue?

@rjbou rjbou added this to To do in Opam 2.2.0 via automation Nov 3, 2021
@rjbou rjbou added this to the 2.2.0~alpha milestone Nov 3, 2021
@rjbou rjbou added the KIND: BUG label Nov 3, 2021
Opam 2.2.0 automation moved this from To do to Done Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Opam 2.2.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants