Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn about actions on pinned packages #4925

Closed
ulugbekna opened this issue Nov 22, 2021 · 2 comments · Fixed by #4987
Closed

Warn about actions on pinned packages #4925

ulugbekna opened this issue Nov 22, 2021 · 2 comments · Fixed by #4987
Labels

Comments

@ulugbekna
Copy link

Currently, if a user has a package pinned, they can reinstall a certain version of the package, but they'll still have the pinned version. Say, I pin ocamlformat master, then reinstall 0.19.0 successfully as indicated by opam install, but I'll still have the master version of ocamlformat when I run it. Does it make sense to warn that the package being (re)installed is actually pinned and the reinstallation, for example, won't do anything? (it probably still changes versions for the solver to see)

@rjbou
Copy link
Collaborator

rjbou commented Nov 24, 2021

On its display opam already say you that it is synchronising pinned packages, even if there is not changes:

<><> Synchronising pinned packages ><><><><><><><><><><><><><><><><><><><><><><>
[name.version] synchronised (no changes)

The following actions will be performed:

@rjbou rjbou added the AREA: UI label Dec 1, 2021
@dra27
Copy link
Member

dra27 commented Dec 14, 2021

Notes from dev meeting: we should change the display of pinned versioned so that instead of just being version* it is version (pinned). Separately, we should also consider using a suffix on the version by default (although this may potentially break workflows, so it's worth considering the two changes separately)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants