Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request + Question] Vendored mode has been automatically enabled #5271

Closed
sidkshatriya opened this issue Sep 3, 2022 · 4 comments · Fixed by #5277
Closed

[Feature Request + Question] Vendored mode has been automatically enabled #5271

sidkshatriya opened this issue Sep 3, 2022 · 4 comments · Fixed by #5277
Projects
Milestone

Comments

@sidkshatriya
Copy link

sidkshatriya commented Sep 3, 2022

I'm trying to build opam from scratch. When I run ./configure --prefix=... I get the following message:

Downloading vendored dependencies... done
Extracting vendored dependencies... done

There is no other information presented. What exactly is being downloaded and from where? How is it being downloaded (e.g. via http or https, is it checksummed?)

What are these vendored dependencies? Are they binaries? Source code?

I'll also try explore the scripts and find out for myself but I'd greatly appreciate if anyone can answer the above questions if they get a chance.

My feature request for opam developers would be to present more detailed information to the end user relating to this vendoring (as configure executes). This will improve transparency and confidence in the compilation process of opam.

@sidkshatriya
Copy link
Author

I'm noticing that a lot of these vendored dependencies are going into ./src_ext

@dra27 dra27 linked a pull request Sep 7, 2022 that will close this issue
@dra27
Copy link
Member

dra27 commented Sep 7, 2022

It is indeed downloading source dependencies to src_ext/. I've opened #5277 which explains what's happening a bit more clearly.

When compiling an official release from a source tarball, the source tarballs are included with it, so the download stage doesn't actually perform any network access.

@sidkshatriya
Copy link
Author

sidkshatriya commented Sep 7, 2022

Thanks for looking at this so promptly! I was trying to compile from the master branch btw and not a tarball.

It would also be great for the download process to be a bit more verbose (if you're doing this in a shell script, even a set -x would work!). It would be useful to know which URLs are being hit and any checksum verification being done.

@kit-ty-kate
Copy link
Member

@sidkshatriya I added a commit to #5277, this should now be verbose enough

@rjbou rjbou added this to the 2.2.0~alpha milestone Oct 14, 2022
@rjbou rjbou added this to To do in Opam 2.2.0 via automation Oct 14, 2022
@rjbou rjbou moved this from To do to Done in Opam 2.2.0 Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Opam 2.2.0
  
Done
Development

Successfully merging a pull request may close this issue.

4 participants