Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken url in warning 62 (SPDX license standard) #5570

Closed
3Rafal opened this issue Jun 6, 2023 · 5 comments · Fixed by #5571
Closed

Broken url in warning 62 (SPDX license standard) #5570

3Rafal opened this issue Jun 6, 2023 · 5 comments · Fixed by #5571
Projects
Milestone

Comments

@3Rafal
Copy link
Contributor

3Rafal commented Jun 6, 2023

URL in warning 62 gets parsed by tools such as Github action as: https://spdx.org/licenses/:

See below example:
Screenshot 2023-06-06 at 14 28 06

@rjbou
Copy link
Collaborator

rjbou commented Jun 6, 2023

Can you describe the consequences of this parsing ?

@dbuenzli
Copy link
Contributor

dbuenzli commented Jun 6, 2023

404 :-)

@rjbou
Copy link
Collaborator

rjbou commented Jun 6, 2023

oh ok!

@3Rafal
Copy link
Contributor Author

3Rafal commented Jun 6, 2023

Yup, funnily enough the parsing in Github comment parses colon differently:
https://spdx.org/licenses/:

@dbuenzli
Copy link
Contributor

dbuenzli commented Jun 6, 2023

That's the github flavoured markdown autolink extension in action. I prefer the commonmark way which is to always require to delineate them with angle brackets, as the URI rfc suggests. Less ambiguities.

@rjbou rjbou added this to the 2.2.0~alpha milestone Jun 9, 2023
@rjbou rjbou added this to To do in Opam 2.2.0 via automation Jun 9, 2023
@rjbou rjbou moved this from To do to Done in Opam 2.2.0 Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Opam 2.2.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants